Skip to content

chore: Migrate crates to Rust Edition 2024 (part 5/N) #22196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 12, 2025
Merged

chore: Migrate crates to Rust Edition 2024 (part 5/N) #22196

merged 2 commits into from
Nov 12, 2025

Conversation

@moulins
Copy link
Contributor

@moulins moulins commented Nov 10, 2025

(part 4: #22186)

Migrates the web/* and tests/* crates; only core remains in edition 2021 now.

@moulins moulins added A-web Area: Web & Extensions A-tests Area: Tests & Test Framework T-chore Type: Chore (like updating a dependency, it's gotta be done) labels Nov 10, 2025
@moulins
Copy link
Contributor Author

moulins commented Nov 10, 2025 •
edited
Loading

Switching web/packages/extension/safari to edition 2024 causes objc's class! macro to fire this warning:

warning: unexpected `cfg` condition value: `cargo-clippy`
 --> web/packages/extension/safari/src/main.rs:8:63
  |
8 |         let mut ruffle = ClassDecl::new("RuffleWebExtension", class!(NSObject))
  |                                                               ^^^^^^^^^^^^^^^^
  |
  = note: no expected values for `feature`
  = note: using a cfg inside a macro will use the cfgs from the destination crate and not the ones from the defining crate
  = help: try referring to `class` crate for guidance on how handle this unexpected cfg
  = help: the macro `class` may come from an old version of the `objc` crate, try updating your dependency with `cargo update -p objc`
  = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
  = note: `#[warn(unexpected_cfgs)]` on by default
  = note: this warning originates in the macro `class` (in Nightly builds, run with -Z macro-backtrace for more info)

objc is unmaintained, so let's switch to the better-maintained objc2 instead.

EDIT: and now there's another failure... :c
EDIT 2: CI passes now, hopefully the safari extension builds properly... (I don't have an iPad/iPhone/iMac to test with)

@moulins moulins force-pushed the edition-2024-part5 branch 6 times, most recently from 75438df to 4743ad7 Compare November 10, 2025 09:52
@moulins moulins added the waiting-on-review Waiting on review from a Ruffle team member label Nov 10, 2025
@kjarosh kjarosh added A-other Area: Not covered by other area labels and removed A-web Area: Web & Extensions A-tests Area: Tests & Test Framework labels Nov 10, 2025
@moulins
chore: migrate web/* crates to edition 2024
6e37a39 
The `obj2` crate now causes a warning ("unexpected `cfg` condition value: `cargo-clippy`")
and is unmaintained, so this switches to the better-maintained `objc2` fork
(https://github.com/madsmtm/objc2).
@moulins
chore: migrate tests/* crates to edition 2024
1885125
@moulins moulins merged commit 5922c59 into ruffle-rs:master Nov 12, 2025
26 checks passed
@moulins moulins deleted the edition-2024-part5 branch November 12, 2025 15:19
Hancock33 added a commit to Hancock33/batocera.piboy that referenced this pull request Nov 16, 2025
@Hancock33
Updates on Nov 13, 2025 20:36
5d1b68b 
-------------------------------------------------------------
chromebook-ucm-conf.mk 0.8 # Version: Commits on Nov 13, 2025
-------------------------------------------------------------
**Full Changelog**: WeirdTreeThing/alsa-ucm-conf-cros@0.7...0.8

------------------------------------------------------------------------------------------
dolphin-emu.mk 0c349306e3dd00864707a5ca7769c4e7afc6278e # Version: Commits on Nov 13, 2025
------------------------------------------------------------------------------------------
Merge pull request #14092 from Simonx22/curl-8.15.0

curl: Update to 8.15.0,

------------------------------------------------------------------------------------------
duckstation.mk 4c56f06ffeee5eaadee622d45f1d764049615466 # Version: Commits on Nov 13, 2025
------------------------------------------------------------------------------------------
Qt: Style check boxes in Darker Fusion,

-----------------------------------------------------------------------------------
eden.mk 32db6c18779a3e69b065ecbd68be2b61cb2a9c4d # Version: Commits on Nov 13, 2025
-----------------------------------------------------------------------------------
[renderer] NG ragebound workaround via LoadOverrides &#43; vk_rasterizer UpdateBlending TouchBlendequations Rework (#2934)

--------------------------------------------------------------------------------------
flycast.mk 98db7a6cd513118c3822f3ae0a8a19b4aeb0cd01 # Version: Commits on Nov 13, 2025
--------------------------------------------------------------------------------------
android: vgamepad LT and RT not set to minimum when released

LT and RT were left to 50% depressed when released.

Regression due to 7b0c106fc2f388afa9abbb535437fa0bfe1afc0a

Issue #2104,

----------------------------------------------------
pcsx2.mk v2.5.288 # Version: Commits on Nov 13, 2025
----------------------------------------------------
- [Qt: Fix game list deadlock when changing discs](PCSX2/pcsx2#13493)

-------------------------------------------------------------------------------------
ppsspp.mk 35a084bfaaae2e8263ec99999d770767f93f108c # Version: Commits on Nov 13, 2025
-------------------------------------------------------------------------------------
Merge pull request #20996 from bilginGamer/master

minor corrections to the translation az_AZ,

-----------------------------------------------------------------------------------------
supermodel.mk c995ce547756d6642bd44b5391e062a1140aef06 # Version: Commits on Nov 13, 2025
-----------------------------------------------------------------------------------------
Build release target in GitHub workflow to compile version string into application binary,

-------------------------------------------------
vice.mk r45822 # Version: Commits on Nov 13, 2025
-------------------------------------------------
monitor: fix bug 2177

If we are leaving the monitor with a change in program flow, and there is a breakpoint on the new address, take the breakpoint right away instead of leaving the monitor.

The monitor command \G XXXX\ is considered a change in flow.

This is because of the structure of the DO_INTERRUPT() macro, which can enter the monitor under different conditions in different places, but each only once per executed instruction.

git-svn-id: https://svn.code.sf.net/p/vice-emu/code/trunk@45822 379a1393-f5fb-40a0-bcee-ef074d9b53f7,

-------------------------------------------------------------------------------------------
xenia-native.mk 09b9e37c4ff63a46bdf04bb006a6923e7334eb0a # Version: Commits on Nov 13, 2025
-------------------------------------------------------------------------------------------
Revert \[Kernel] Fixed invalid address of a native object pointer\

This reverts commit 68b3490c8bdb2a819e80b113457aa16c6634118e.,

---------------------------------------------------------------
ruffle.mk nightly-2025-11-13 # Version: Commits on Nov 13, 2025
---------------------------------------------------------------
## What's Changed

* chore: Migrate crates to Rust Edition 2024 (part 5/N) by @moulins in ruffle-rs/ruffle#22196

* chore: Update translations from Crowdin by @kjarosh in ruffle-rs/ruffle#22223

**Full Changelog**: ruffle-rs/ruffle@nightly-2025-11-12...nightly-2025-11-13,

------------------------------------------------------------------------------------
box64.mk c6e9b87ef36becacd5ecb158e963c2b3cfbda19e # Version: Commits on Nov 13, 2025
------------------------------------------------------------------------------------
[RV64_DYNAREC] Added more lock opcodes (#3171),

------------------------------------------------------------------------------------------
devilutionx.mk b30df6341e1207d4a1848c5576e1f2534d88cf67 # Version: Commits on Nov 13, 2025
------------------------------------------------------------------------------------------
Fix compiler warning about cases not handled in switch (#8262),

---------------------------------------------------------------------------------------
etlegacy.mk 36c31ba41e257763b177ea5b7a58520fb7cd98e2 # Version: Commits on Nov 13, 2025
---------------------------------------------------------------------------------------
cgame: this part of code was never accessible beacuse of missing letter W,

----------------------------------------------------------------------------------------
openmohaa.mk 5df5735965298b26b9bd4b90034843c743ff7158 # Version: Commits on Nov 12, 2025
----------------------------------------------------------------------------------------
fix(fgame): remove view-model states and only cache players' world model (#829)

Caching all FPS models would create too many unnecessary entries. On some maps, this would cause clients to reach the MAX_MOD_KNOWN limit, causing crashes.,

--------------------------------------------------------------------------------------
stalker.mk 756cbb947a7f1279e6117a92e33c497dd485b89f # Version: Commits on Nov 13, 2025
--------------------------------------------------------------------------------------
fix: use-after-free in `CUIDebugger` on exit (#1987),

---------------------------------------------------------------------------------------
mangohud.mk a523979d7ef717c8d62dbab263ea1140fd6cd911 # Version: Commits on Nov 13, 2025
---------------------------------------------------------------------------------------
bugfix: present mode value text alignment.,

-------------------------------------------------------------------------------------------------
libretro-core-info.mk 938f24313afe37f62ac122bb77980decdf1b1b4f # Version: Commits on Nov 13, 2025
-------------------------------------------------------------------------------------------------
Update pcsx2_libretro.info,

----------------------------------------------------------------------------------------
retroarch.mk 5650d916084e8029c5e8592d76287f19600066f1 # Version: Commits on Nov 13, 2025
----------------------------------------------------------------------------------------
Silence warnings,

----------------------------------------------------------------------------------------
doomretro.mk d9e7252420fa098c1af8321581049eb9337c05f3 # Version: Commits on Nov 13, 2025
----------------------------------------------------------------------------------------
Minor tweaks,

----------------------------------------------------------------------------------
trx.mk fcccbc876c1ae671b985e8b44815960c2ee7aece # Version: Commits on Nov 13, 2025
----------------------------------------------------------------------------------
rooms/floor_data: respect first portal room only

In the original GetDoor function, the floor data was parsed until it

reached a portal instance and returned that room number. With managed

FD, editor bugs where more than one portal is defined per sector

mean that the last entry is used, which can result in Lara getting

stuck. This ensures the first portal is the only one adhered to.,

------------------------------------------------------------------------------------------
xash3d-fwgs.mk 747baa1e166a6ab208e06926db6a1d05275445ae # Version: Commits on Nov 13, 2025
------------------------------------------------------------------------------------------
engine: client: additionally look for loading images with bmp and png extensions,

-----------------------------------------------------------------------------------------------
libretro-flycast.mk 98db7a6cd513118c3822f3ae0a8a19b4aeb0cd01 # Version: Commits on Nov 13, 2025
-----------------------------------------------------------------------------------------------
android: vgamepad LT and RT not set to minimum when released

LT and RT were left to 50% depressed when released.

Regression due to 7b0c106fc2f388afa9abbb535437fa0bfe1afc0a

Issue #2104,

----------------------------------------------------------------------------------------------
libretro-ppsspp.mk 35a084bfaaae2e8263ec99999d770767f93f108c # Version: Commits on Nov 13, 2025
----------------------------------------------------------------------------------------------
Merge pull request #20996 from bilginGamer/master

minor corrections to the translation az_AZ,

-------------------------------------------------------------------------------------------
libretro-ps2.mk 607bebd9404aa35015da5b001da0a42cba6e7a05 # Version: Commits on Nov 13, 2025
-------------------------------------------------------------------------------------------
Restore code,

---------------------------------------------------------------------------------------------
libretro-vba-m.mk ce9aa7949a7e8d71c3dad97b68db799f89f5e01c # Version: Commits on Nov 13, 2025
---------------------------------------------------------------------------------------------
Days above 255 would have been broken without this

ie, 44 instead of 300.,

--------------------------------------------------------------------------------------------
slang-shaders.mk 7b0fb588c7cf00ff64703a5ffacebd5f491f40db # Version: Commits on Nov 13, 2025
--------------------------------------------------------------------------------------------
clean-up, keep XL version only in SLANG (#795)

* Delete crt/crt-consumer-1w-ntsc.slangp

* Update zfast_crt_composite.slang,
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lord-McSweeney Lord-McSweeney Lord-McSweeney approved these changes

Assignees

No one assigned

Labels

A-other Area: Not covered by other area labels T-chore Type: Chore (like updating a dependency, it's gotta be done) waiting-on-review Waiting on review from a Ruffle team member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@moulins @Lord-McSweeney @kjarosh